Skip to content

make.yml: reduce binary size#12247

Open
oech3 wants to merge 2 commits into
uutils:mainfrom
oech3:unex-uchunk
Open

make.yml: reduce binary size#12247
oech3 wants to merge 2 commits into
uutils:mainfrom
oech3:unex-uchunk

Conversation

@oech3

@oech3 oech3 commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rust no longer remove unwind tables by panic=abort

@codspeed-hq

codspeed-hq Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 319 untouched benchmarks
⏩ 46 skipped benchmarks1

Comparing oech3:unex-uchunk (071ea1e) with main (a2d29c0)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (ef5155a) during the generation of this report, so a2d29c0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@oech3 oech3 closed this May 12, 2026
@oech3 oech3 deleted the unex-uchunk branch May 12, 2026 07:53
@oech3 oech3 restored the unex-uchunk branch May 16, 2026 12:48
@oech3 oech3 reopened this May 16, 2026
@oech3 oech3 changed the title unexpand: use utf8_chunks make.tml: reduce binary size May 16, 2026
@oech3 oech3 changed the title make.tml: reduce binary size make.yml: reduce binary size May 16, 2026
@github-actions

github-actions Bot commented May 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 146.59 MB (-4.91 MB, -3.24%)

Significant per-binary changes:
  date       2.73 MB ->    2.50 MB  (-244 KB, -8.71%)
  pr         2.84 MB ->    2.65 MB  (-196 KB, -6.73%)
  ptx        2.57 MB ->    2.38 MB  (-196 KB, -7.45%)
  csplit     2.51 MB ->    2.32 MB  (-192 KB, -7.48%)
  nl         2.48 MB ->    2.30 MB  (-192 KB, -7.55%)
  tac        2.48 MB ->    2.29 MB  (-192 KB, -7.57%)

@oech3 oech3 mentioned this pull request May 16, 2026
Closed
@oech3 oech3 force-pushed the unex-uchunk branch 2 times, most recently from e83de1b to 9bb92a1 Compare May 17, 2026 01:33
@oech3 oech3 marked this pull request as ready for review May 17, 2026 01:42
@github-actions

github-actions Bot commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

sylvestre
sylvestre reviewed May 20, 2026
View reviewed changes

@sylvestre sylvestre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strip and pack-relative-relocs flags make sense for size-tracking CI.

One note: -C force-unwind-tables=no trades debuggability for size — worth noting in the commit message that this is intentional for the size-measurement job.

@oech3
make.yml: reduce binary size
3de6952 
* replace manuall strip by RUSTFLAGS
* use linker flags useful to reduce binary size
* remove unwind table by -C force-unwind-tables=no.

Unwind tables are useful for debug.
but we publish milti-call binary containing them from
CICD.yml and individual binaries from size CI.
So we dont hurt debuggability for size bench.
@oech3 oech3 force-pushed the unex-uchunk branch 2 times, most recently from 0502633 to 3de6952 Compare May 20, 2026 16:15
sylvestre
sylvestre reviewed May 20, 2026
View reviewed changes
Comment thread .github/workflows/make.yml
@oech3 @sylvestre
make.yml: add comment about binary size
071ea1e 
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
@oech3 oech3 requested a review from sylvestre May 28, 2026 01:18
@oech3

oech3 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

this pr is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @sylvestre